Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noFallthroughSwitchClause #4626

Merged
merged 6 commits into from
Jul 7, 2023
Merged

feat(rome_js_analyze): noFallthroughSwitchClause #4626

merged 6 commits into from
Jul 7, 2023

Conversation

ddanielsantos
Copy link
Contributor

@ddanielsantos ddanielsantos commented Jun 28, 2023 •
edited
Loading

Summary

  • adds a new rule

Closes #3973

Test Plan

cargo test -p rome_js_analyze -- no_fallthrough_switch_clause

@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited
Loading

✅ Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b67ad0f
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64a774a3de7f30000722bc3e
😎 Deploy Preview https://deploy-preview-4626--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading labels Jun 28, 2023
ematipico
ematipico approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! Thank you! You should rebase your branch and resolve the conflicts. Just use just ready and commit anything that gets generated.

@github-actions github-actions bot added A-Core Area: core A-Formatter Area: formatter A-CLI Area: CLI A-Parser Area: parser A-LSP Area: language server protocol A-Tooling Area: our own build, development, and release tooling labels Jul 4, 2023
@ematipico
Copy link
Contributor

@ddanielsantos, I believe something went wrong with your branch, probably when you merged or rebased. It seems you did both?. Your PR has code that is not related to it.

Would you mind looking at it?

@ddanielsantos
Copy link
Contributor Author

I ended up messing up some things, would it be better if I opened another PR with the valid contents of this one?

@ematipico
Copy link
Contributor

You can still use this PR. You could rebase locally your branch and remove the last two commits.

git rebase -i HEAD~3 and drop the last two commits (and keep the third).

Then just do a merge. It should be fine.

If that doesn't go well, then you could create a new PR.

@Conaclos
Copy link
Contributor

Conaclos commented Jul 4, 2023

You can also rename your current branch and create a new branch with the old name. By pushing this new branch you are likely to push on this PR.

@ddanielsantos
Copy link
Contributor Author

ok i will do it

@github-actions github-actions bot removed A-Core Area: core A-Formatter Area: formatter A-Parser Area: parser A-LSP Area: language server protocol A-Tooling Area: our own build, development, and release tooling labels Jul 5, 2023
@ematipico
Copy link
Contributor

@ddanielsantos, almost there! The CI found a small error

@ematipico ematipico merged commit db94996 into rome:main Jul 7, 2023
17 checks passed
@ddanielsantos
Copy link
Contributor Author

Thanks for your patience guys!

@Conaclos
Copy link
Contributor

Conaclos commented Jul 7, 2023

Thanks to you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

@Conaclos Conaclos Conaclos approved these changes

Assignees
No one assigned
Labels
A-CLI Area: CLI A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

noFallthoughSwitchClause, no-fallthrough
3 participants
@ddanielsantos @ematipico @Conaclos